[IR2VEC] Rewrite triples.mir and entities.mir. NFC #168574
Merged
+43
−7,196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemgreen
force-pushed
the
gh-ir2vec-badtests
branch
from
58e759a to
a35ceac
Compare
🐧 Linux x64 Test Results
|
arsenm
approved these changes
Nov 18, 2025
svkeerthy
approved these changes
Nov 19, 2025
Contributor
svkeerthy
left a comment
svkeerthy
left a comment
There was a problem hiding this comment.
Thanks for the patch. We kept it this way to track any changes in the IR. We now plan to setup buildbot to do this. Current changes look good to me.
These test change and need updating every time a new instruction is added, including generic G_ global isel instructions. The opcodes of all instructions change force a manual update of the file, which makes it very high cost for what it is testing. I have rewritten it to use regexes for the triplets.mir test and just test a couple of opcodes in the entities.mir file. Also change them from REQUIRES: x86_64-linux to REQUIRES: x86-registered-target, as they should run fine on other targets providing that the triple is used correctly. It passes successfully on an AArch64 box I tried it on.
davemgreen
force-pushed
the
gh-ir2vec-badtests
branch
from
a35ceac to
822b017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test change and need updating every time a new instruction is added, including generic G_ global isel instructions. The opcodes of all instructions change force a manual update of the file, which makes it very high cost for what it is testing.
I have rewritten it to use regexes for the triplets.mir test and just test a couple of opcodes in the entities.mir file.